Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error struct with default impl #3190

Merged
merged 5 commits into from
Nov 14, 2023
Merged

Fix error struct with default impl #3190

merged 5 commits into from
Nov 14, 2023

Commits on Nov 14, 2023

  1. Fix error struct with default impl

    @codypenta @rcoh
    codypenta authored and rcoh committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    ef2b886 View commit details
    Browse the repository at this point in the history

  2. Fix error struct with default impl

    @codypenta @rcoh
    codypenta authored and rcoh committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    ac51df5 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: John DiSanti <[email protected]>
    @codypenta @jdisanti @rcoh
    2 people authored and rcoh committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    04c9610 View commit details
    Browse the repository at this point in the history

  4. Add client integration isolation test for error struct impl

    @codypenta @rcoh
    codypenta authored and rcoh committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    6ec442c View commit details
    Browse the repository at this point in the history

  5. Revert change to Error struct

    @codypenta @rcoh
    codypenta authored and rcoh committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    7295190 View commit details
    Browse the repository at this point in the history