-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return impl AsyncBufRead from into_async_read #3164
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdisanti
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this! ❤️
It looks like the changes to the example aren't compiling:
|
utkarshgupta137
force-pushed
the
main
branch
2 times, most recently
from
November 9, 2023 19:11
5ca448a
to
f9f9305
Compare
Fixed. |
utkarshgupta137
force-pushed
the
main
branch
from
November 10, 2023 01:15
f9f9305
to
4844b17
Compare
Fix path for async-buf read
I fixed external types, CI should pass now I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The tokio
StreamReader
implementsAsyncBufRead
, but we're returningAsyncRead
currently. If a user needs anAsyncBufRead
, then they've to wrap the returned value in tokioBufReader
for no reason. SinceByteStream
doesn't implementStream
anymore, one has to either wrap the returned value unnecessarily or write a wrapper similar to this function.See #2983 (comment).
Description
Simply changed the return type to say
impl AsyncBufRead
. SinceAsyncBufRead
is a super-set ofAsyncRead
, this is not a breaking change.Testing
The code example tests it.
Checklist
CHANGELOG.next.toml
if I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.