Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename orchestrator traits to be verbs #3065

Merged
merged 12 commits into from
Oct 13, 2023
Merged

Rename orchestrator traits to be verbs #3065

merged 12 commits into from
Oct 13, 2023

Conversation

jdisanti
Copy link
Collaborator

@jdisanti jdisanti commented Oct 12, 2023

This PR makes the orchestrator traits more idiomatic by making them verbs.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jdisanti jdisanti added breaking-change This will require a breaking change needs-sdk-review labels Oct 12, 2023
@jdisanti jdisanti requested review from a team as code owners October 12, 2023 22:59
@jdisanti
Copy link
Collaborator Author

I didn't rename HttpClient, HttpConnector, RuntimePlugin, AuthScheme, or RetryStrategy since I couldn't think of good names for these, and was worried alternate names for them might make things less clear.

@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@jdisanti jdisanti enabled auto-merge October 13, 2023 17:49
@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@jdisanti jdisanti added this pull request to the merge queue Oct 13, 2023
Merged via the queue into main with commit 63ce3f9 Oct 13, 2023
40 of 41 checks passed
@jdisanti jdisanti deleted the jdisanti-rename-traits branch October 13, 2023 19:14
landonxjames added a commit that referenced this pull request Nov 19, 2024
Aligns with standard introduced in #3065
landonxjames added a commit that referenced this pull request Nov 19, 2024
Aligns with standard introduced in #3065

Update doc comments
landonxjames added a commit that referenced this pull request Nov 19, 2024
Aligns with standard introduced in #3065

Update doc comments

External types updates
landonxjames added a commit that referenced this pull request Nov 25, 2024
Aligns with standard introduced in #3065

Update doc comments

External types updates
landonxjames added a commit that referenced this pull request Dec 3, 2024
Aligns with standard introduced in #3065

Update doc comments

External types updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This will require a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants