Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove once_cell from public API #2973

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Remove once_cell from public API #2973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81a3b06
Remove `once_cell` from public API
ysaito1001 Sep 5, 2023
423eccd
Update CHANGELOG.next.toml
ysaito1001 Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions CHANGELOG.next.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,3 +102,15 @@ message = "Required members with @contextParam are now treated as client-side re
references = ["smithy-rs#2964"]
meta = { "breaking" = false, "tada" = false, "bug" = false, target = "client" }
author = "rcoh"

[[aws-sdk-rust]]
message = "Remove `once_cell` from public API"
references = ["smithy-rs#2973"]
meta = { "breaking" = true, "tada" = false, "bug" = false }
author = "ysaito1001"

[[smithy-rs]]
message = "Remove `once_cell` from public API"
references = ["smithy-rs#2973"]
meta = { "breaking" = true, "tada" = false, "bug" = false, "target" = "all" }
author = "ysaito1001"
3 changes: 0 additions & 3 deletions rust-runtime/aws-smithy-http/external-types.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@ allowed_external_types = [
# TODO(https://github.com/awslabs/smithy-rs/issues/1193): Feature gate references to Tokio `File`
"tokio::fs::file::File",

# TODO(https://github.com/awslabs/smithy-rs/issues/1193): Don't expose `once_cell` in public API
"once_cell::sync::Lazy",

# TODO(https://github.com/awslabs/smithy-rs/issues/1193): Once tooling permits it, only allow the following types in the `event-stream` feature
"aws_smithy_eventstream::*",
]
17 changes: 0 additions & 17 deletions rust-runtime/aws-smithy-http/src/http_versions.rs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion rust-runtime/aws-smithy-http/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ pub mod body;
pub mod endpoint;
pub mod header;
pub mod http;
pub mod http_versions;
pub mod label;
pub mod middleware;
pub mod operation;
Expand Down