Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove futures_core::stream::Stream from public API #2910

Closed
wants to merge 41 commits into from
Closed

Remove futures_core::stream::Stream from public API #2910

wants to merge 41 commits into from

Commits on Aug 8, 2023

  1. Remove futures_core::stream::Stream from smithy-async

    @ysaito1001
    ysaito1001 committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    6b308e4 View commit details
    Browse the repository at this point in the history

  2. Remove futures_core::stream::Stream from smithy-http

    @ysaito1001
    ysaito1001 committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    9a27075 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Remove futures_core::stream::Stream from Paginator

    @ysaito1001
    ysaito1001 committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    f5b440c View commit details
    Browse the repository at this point in the history

  2. Remove futures_core::stream::Stream from integration tests

    @ysaito1001
    ysaito1001 committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    2bcf9b5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into ysaito/remove-futures-stream-from-public-api

    @ysaito1001
    ysaito1001 committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    6e31754 View commit details
    Browse the repository at this point in the history

  4. Fix links in docs

    @ysaito1001
    ysaito1001 committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    181440d View commit details
    Browse the repository at this point in the history

  5. Fix codegen-server-test:test

    @ysaito1001
    ysaito1001 committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    f00d605 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Fix tests in CI

    @ysaito1001
    ysaito1001 committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    3e05c47 View commit details
    Browse the repository at this point in the history

  2. Update pokemon example to use FnStream

    @ysaito1001
    ysaito1001 committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    8e90987 View commit details
    Browse the repository at this point in the history

  3. Fix more server tests

    @ysaito1001
    ysaito1001 committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    492e8bf View commit details
    Browse the repository at this point in the history

  4. Fix test name that checks both Send and Sync

    @ysaito1001
    ysaito1001 committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    2c7541b View commit details
    Browse the repository at this point in the history

  5. Fix event-streaming tests in pokemon-service

    @ysaito1001
    ysaito1001 committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    f7e8a69 View commit details
    Browse the repository at this point in the history

  6. Let ser_* return concreate types instead of impl Stream

    @ysaito1001
    ysaito1001 committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    f3dae46 View commit details
    Browse the repository at this point in the history

  7. Port event_stream_input_ergonomics test

    @ysaito1001
    ysaito1001 committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    3aae470 View commit details
    Browse the repository at this point in the history

  8. Remove unused dependency from aws-smithy-async

    @ysaito1001
    ysaito1001 committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    3944bb3 View commit details
    Browse the repository at this point in the history

  9. Update pokemon-service-test to use FnStream

    @ysaito1001
    ysaito1001 committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    fd70e49 View commit details
    Browse the repository at this point in the history

  10. Remove unused tokio_stream::StreamExt from canary-lambda

    @ysaito1001
    ysaito1001 committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ae047e5 View commit details
    Browse the repository at this point in the history

  11. Tell udeps futures_util is used

    @ysaito1001
    ysaito1001 committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    50fe74c View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Update latest for canary-lambda

    @ysaito1001
    ysaito1001 committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    ccf9d06 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Append release-2023-08-03 to NOTABLE_SDK_RELEASE_TAGS 

    This commit appends `release-2023-08-03` to `NOTABLE_SDK_RELEASE_TAGS`.
Elements in that `Vec` should be sorted in an ascending order for a
function `enabled_feature` to work correctly. The change has been
verified by the following (each executed from canary-runner directory)
```
cargo run -- build-bundle \
  --sdk-release-tag release-2023-08-03 \
  --canary-path ../canary-lambda \
  --manifest-only --musl && \
cd ../canary-lambda && \
cargo check
```

```
cargo run -- build-bundle \
  --sdk-release-tag release-2023-05-24 \
  --canary-path ../canary-lambda \
  --manifest-only --musl && \
cd ../canary-lambda && \
cargo check
```

```
cargo run -- build-bundle \
  --sdk-release-tag release-2023-12-14 \
  --canary-path ../canary-lambda \
  --manifest-only --musl && \
cd ../canary-lambda && \
cargo check
    @ysaito1001
    ysaito1001 committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    d31669b View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Add dependency on aws-smithy-async

    @ysaito1001
    ysaito1001 committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    f8c0c40 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into ysaito/remove-futures-stream-from-public-api

    @ysaito1001
    ysaito1001 committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    66420d5 View commit details
    Browse the repository at this point in the history

  3. Remove 2023_01_26 that is more than 3 releases ago

    @ysaito1001
    ysaito1001 committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    d853cb1 View commit details
    Browse the repository at this point in the history

  4. Update CHANGELOG.next.toml

    @ysaito1001
    ysaito1001 committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    5f65dff View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Remove code duplication in calling renderEventStreamBody 

    This commit addresses #2910 (comment)
    @ysaito1001
    ysaito1001 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    6abb519 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Remove uncecessary CollectablePrivate 

    This commit addresses #2910 (comment)
    @ysaito1001
    ysaito1001 committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    0491221 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. Use customization to wrap stream payload in new-type 

    This commit addresses #2910 (comment)
    @ysaito1001
    ysaito1001 committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    bedfb04 View commit details
    Browse the repository at this point in the history

  2. Let finalize take an owned associated collection 

    This commit addresses #2910 (comment)
    @ysaito1001
    ysaito1001 committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    5698ee3 View commit details
    Browse the repository at this point in the history

  3. Reexport FnStream and remove dependency on aws-smithy-async 

    This commit addresses #2910 (comment)
    @ysaito1001
    ysaito1001 committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    d9052d5 View commit details
    Browse the repository at this point in the history

  4. Remove dependency on aws-smithy-async and use reexported FnStream

    @ysaito1001
    ysaito1001 committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    b281aee View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into ysaito/remove-futures-stream-from-public-api

    @ysaito1001
    ysaito1001 committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    d0452a0 View commit details
    Browse the repository at this point in the history

  6. Return size hint as is by http_body::Body::size_hint 

    This commit addresses #2910 (comment)
    @ysaito1001
    ysaito1001 committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    0f5f6be View commit details
    Browse the repository at this point in the history

  7. Add an comment FnStream is Send not Sync 

    This commit addresses #2910 (comment)
    @ysaito1001
    ysaito1001 committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    d2e4411 View commit details
    Browse the repository at this point in the history

  8. Add more comments as to why generator can be set to None 

    This commit addresses #2910 (comment)
    @ysaito1001
    ysaito1001 committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    a778886 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into ysaito/remove-futures-stream-from-public-api

    @ysaito1001
    ysaito1001 committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    292a51b View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Convert StreamPayloadSerializer to interface 

    This commit addresses #2910 (comment)
    @ysaito1001
    ysaito1001 committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    ab57dce View commit details
    Browse the repository at this point in the history

  2. Add comments to data class for ServerHttpBoundProtocolSection 

    This commit addresses #2910 (comment)
    @ysaito1001
    ysaito1001 committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    3db0525 View commit details
    Browse the repository at this point in the history

  3. Use ServiceShape.hasEventStreamOperations 

    This commit addresses #2910 (comment)
    @ysaito1001
    ysaito1001 committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    91163de View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Move hyper_body_wrap_stream from inlineable to aws-smithy-http 

    This commit addresses #2910 (comment).
Now that `HyperBodyWrapByteStream` is also used outside the context of
`hyper::body::Body::wrap_stream` (passed to `tokio_util::io::StreamReader`),
the module has been renamed to `futures_stream_adapter`. Furthermore,
`HyperBodyWrapByteStream` and `HyperBodyWrapEventStream` have been
renamed to `FuturesStreamCompatByteStream` and
`FuturesStreamCompatEventStream` respectively.
    @ysaito1001
    ysaito1001 committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    f5c8a96 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. Merge branch 'main' into ysaito/remove-futures-stream-from-public-api

    @ysaito1001
    ysaito1001 committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    35a1fca View commit details
    Browse the repository at this point in the history

  2. Fix undeclared crate or module for feature-gated types

    @ysaito1001
    ysaito1001 committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    852211f View commit details
    Browse the repository at this point in the history