Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up a default connector for generic clients in the orchestrator implementation #2693

Merged
merged 7 commits into from
May 26, 2023

Conversation

jdisanti
Copy link
Collaborator

Motivation and Context

This PR makes generic clients default to the built-in rustls HTTPS connector when no override is provided, but only for the new orchestrator implementation.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jdisanti
Copy link
Collaborator Author

Note: this PR requires #2675 to be merged first.

@github-actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@jdisanti
Copy link
Collaborator Author

The semver check failure is due to this bug and can be ignored: obi1kenobi/cargo-semver-checks#355

@jdisanti jdisanti force-pushed the jdisanti-sra-default-connector branch from c4bd3d9 to 6819539 Compare May 11, 2023 17:55
@github-actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@jdisanti jdisanti marked this pull request as ready for review May 26, 2023 16:19
@jdisanti jdisanti requested a review from a team as a code owner May 26, 2023 16:19
@github-actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@jdisanti jdisanti enabled auto-merge May 26, 2023 16:50
@jdisanti jdisanti added this pull request to the merge queue May 26, 2023
@github-actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

Merged via the queue into main with commit d912326 May 26, 2023
@jdisanti jdisanti deleted the jdisanti-sra-default-connector branch May 26, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants