Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make minor fixes to the crate claim workflow #2259

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Make minor fixes to the crate claim workflow #2259

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c959e02
Make minor fixes to the crate claim workflow
jdisanti Jan 28, 2023
f271a49
Merge branch 'main' into jdisanti-cleanup-claim-crate-names
jdisanti Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/claim-crate-names.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
# This workflow claims the names of the unpublished crates in this repository
# on crates.io (by publishing a dummy empty package)

# Allow only one release to run at a time
# Allow only one crate claim workflow to run at a time
concurrency:
group: release-smithy-rs
group: claim-crates-smithy-rs
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wouldn't be so good for this workflow to cancel an ongoing release that happens to be running at 11 UTC 😄

cancel-in-progress: true

env:
Expand Down Expand Up @@ -56,6 +56,7 @@ jobs:
claim:
name: Claim crate names
needs:
- main-branch-check
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without depending on this, the two jobs race each other. claim will probably always lose the race, but better not to chance it.

- acquire-base-image
runs-on: ubuntu-latest
steps:
Expand All @@ -65,8 +66,6 @@ jobs:
toolchain: ${{ env.rust_version }}
- name: Checkout smithy-rs
uses: actions/checkout@v3
with:
token: ${{ secrets.RELEASE_AUTOMATION_BOT_PAT }}
Comment on lines -68 to -69
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't needed since we're not pushing to smithy-rs.

- name: Publish to crates.io
shell: bash
env:
Expand Down