Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support compiling to webassembly #2254
feat: support compiling to webassembly #2254
Changes from 17 commits
ffa9923
91a8dcc
1fbd97b
06a62b7
a725e0c
cae60ef
ef00e01
497c4b9
59791df
7478507
56b7b33
d8fcf49
86a5689
c0d61ed
a5b6316
f2d47b5
df4ab9e
154342f
937022c
08df0df
98d336e
45cae40
1687bbc
14e23fb
be22904
6a578ec
1406d42
25c8fd3
4791b46
40136bd
00234f2
40da289
2755357
5fc3dfd
0506f75
bc4f686
d353ac3
0beea87
0d52a87
ffe83ea
0ec8283
01f106c
bc2fe6c
ba00b09
04c7094
7e90fb3
4bfd4e4
5e63eec
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have some prerequisite work to do before this will run in CI. I'll see if I can get around to that today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our best option is to install cargo-wasi then run
cargo wasi test -- --nocapture
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That aspect of it didn't even cross my mind yet 😅
I did the prerequisite work to actually include the tests in the first place in #2255.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the tokio crate, they have a nice a setup for testing against the different webassembly targets: https://github.com/tokio-rs/tokio/blob/06f1a601bb05b1aba9f95020a7fa7572899c588f/.github/workflows/ci.yml#L529-L590