Implement core Smithy endpoint support #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds `Endpoint` to smithy-http & records our design decisions in `endpoint.md`. This provides support for the endpoint trait in Smithy. A design for endpoint discovery is proposed but is not currently implemented.
LucioFranco
approved these changes
Feb 2, 2021
design/src/endpoint.md
Outdated
| // depending on the duration of endpoint expiration, this may be spawned into a separate task to continuously | ||
| // refresh endpoints. | ||
| if tx.needs(endpoint_req) { | ||
| tx.send(client.call(endpoint_req).await) |
There was a problem hiding this comment.
nit: I might break this await out into its own line, I find it makes it easier to digest that there is async work within this block.
|
|
||
| /// API Endpoint | ||
| /// | ||
| /// This implements an API endpoint as specified in https://awslabs.github.io/smithy/1.0/spec/core/endpoint-traits.html |
There was a problem hiding this comment.
I might use a markdown link instead of full link in plain text?
| immutable: bool, | ||
| } | ||
|
|
||
| pub struct EndpointPrefix(String); |
There was a problem hiding this comment.
Does this get cloned often? Maybe make this Arc<str>?
There was a problem hiding this comment.
it gets used as a format! argument normally so I don't think that gets us anything for now
Co-authored-by: Lucio Franco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #109, #165
Description of changes: This commit adds
Endpointto smithy-http & records our design decisions inendpoint.md. This provides support for the endpoint trait in Smithy. A design for endpoint discovery is proposed but is not currently implemented.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.