-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new CI job to check that smithy-rs compiles on 32bit Linux-based targets #1812
Conversation
…2 bits platforms.
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
It looks like |
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
…djust feature gates accordingly.
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
.github/workflows/ci-pr.yml
Outdated
@@ -5,6 +5,7 @@ | |||
|
|||
name: CI | |||
on: | |||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But why would you need this for ci-pr.yml
? It runs every time a PR is updated.
And if it is run via workflow dispatch, how does it get values needed by the PR bot:
issue_number: ${{ github.event.number }}
base_revision: ${{ github.event.pull_request.base.sha }}
head_revision: ${{ github.event.pull_request.head.sha }}
A new generated diff is ready to view.
A new doc preview is ready to view. |
Motivation and Context
Ensure we do not regress on #1810
Description
This initial PR makes sure that
smithy-rs
compiles on a few 32bits Linux-based targets.We do not attempt to run tests on those targets as it would require a more complicated setup via emulation, which (from what I could gather) would be slow to execute and impact our overall CI completion time.
This puts our confidence in correct execution on 32bit targets a bit lower than our confidence when it comes to Windows.
We successfully reproduced the failure experienced by our customers on
powerpc
(see run).This PR depends on the changes in #1811, so it should be merged afterwards.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.