Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new CI job to check that smithy-rs compiles on 32bit Linux-based targets #1812

Merged
merged 46 commits into from
Oct 10, 2022

Conversation

LukeMathWalker
Copy link
Contributor

@LukeMathWalker LukeMathWalker commented Oct 5, 2022

Motivation and Context

Ensure we do not regress on #1810

Description

This initial PR makes sure that smithy-rs compiles on a few 32bits Linux-based targets.
We do not attempt to run tests on those targets as it would require a more complicated setup via emulation, which (from what I could gather) would be slow to execute and impact our overall CI completion time.
This puts our confidence in correct execution on 32bit targets a bit lower than our confidence when it comes to Windows.

We successfully reproduced the failure experienced by our customers on powerpc (see run).

This PR depends on the changes in #1811, so it should be merged afterwards.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

A new generated diff is ready to view.

A new doc preview is ready to view.

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

A new generated diff is ready to view.

A new doc preview is ready to view.

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

A new generated diff is ready to view.

A new doc preview is ready to view.

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

A new generated diff is ready to view.

A new doc preview is ready to view.

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

A new generated diff is ready to view.

A new doc preview is ready to view.

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

A new generated diff is ready to view.

A new doc preview is ready to view.

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

A new generated diff is ready to view.

A new doc preview is ready to view.

@LukeMathWalker LukeMathWalker enabled auto-merge (squash) October 6, 2022 09:37
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

A new generated diff is ready to view.

A new doc preview is ready to view.

@crisidev crisidev disabled auto-merge October 6, 2022 09:41
@LukeMathWalker
Copy link
Contributor Author

It looks like aws-smithy-client has a few more feature-related bugs to squash.

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

A new generated diff is ready to view.

A new doc preview is ready to view.

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

A new generated diff is ready to view.

A new doc preview is ready to view.

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

A new generated diff is ready to view.

A new doc preview is ready to view.

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

A new generated diff is ready to view.

A new doc preview is ready to view.

@github-actions
Copy link

github-actions bot commented Oct 7, 2022

A new generated diff is ready to view.

A new doc preview is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@@ -5,6 +5,7 @@

name: CI
on:
workflow_dispatch:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why would you need this for ci-pr.yml? It runs every time a PR is updated.

And if it is run via workflow dispatch, how does it get values needed by the PR bot:

      issue_number: ${{ github.event.number }}
      base_revision: ${{ github.event.pull_request.base.sha }}
      head_revision: ${{ github.event.pull_request.head.sha }}

@LukeMathWalker LukeMathWalker enabled auto-merge (squash) October 10, 2022 17:23
@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@LukeMathWalker LukeMathWalker merged commit b547045 into main Oct 10, 2022
@LukeMathWalker LukeMathWalker deleted the exotic-ci branch October 10, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants