Protocol tests for ACCEPT header with * #1648
Conversation
Signed-off-by: Daniele Ahmed <[email protected]>
Signed-off-by: Daniele Ahmed <[email protected]>
82marbag
force-pushed
the
accept_header
branch
from
ef6adb7 to
b6b10a6
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
There was a problem hiding this comment.
Can you link to the Smithy PR in a TODO somewhere in the model? So that we don't forget to remove this test when we upgrade to the next Smithy version.
codegen-test/model/misc.smithy
Outdated
| @output | ||
| structure AcceptHeaderStarServiceOutput {} | ||
| @input | ||
| structure AcceptHeaderStarServiceInput {} |
There was a problem hiding this comment.
I think we should dispense of superfluous modeling in the protocol tests, even if they are best practices, to keep the files minimal so readers can easily focus on the modeling aspects of the test that are strictly relevant to what it is testing.
So, e.g. not using @input/@output, using a single AcceptHeaderStarServiceInputOutput structure, not using @idempotent etc.
Signed-off-by: Daniele Ahmed <[email protected]>
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
| @@ -18,6 +18,7 @@ service MiscService { | |||
| ResponseCodeRequiredOperation, | |||
| ResponseCodeHttpFallbackOperation, | |||
| ResponseCodeDefaultOperation, | |||
| AcceptHeaderStarService, | |||
There was a problem hiding this comment.
Shouldn't this be added to codegen-server-test?
There was a problem hiding this comment.
It's a symlink:
$ ls -l codegen-server-test/model/misc.smithy
codegen-server-test/model/misc.smithy -> ../../codegen-test/model/misc.smithy
I added a appliesTo: "server", to run those tests only in the server.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
It was called out in http-rs/http-types#349 that values can take a quoted string in the form of e.g. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Motivation and Context
Add protocol tests for #1646
Testing
./gradlew :codegen-server-test:test && ./gradlew :codegen-test:testChecklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.