Override codegen version commit hash in PR diffs #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
approved these changes
Aug 16, 2022
crisidev
approved these changes
Aug 16, 2022
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
I had to move env variable to shell script because env variables in GitHub action is not propagated to script. Could you please review it again? |
jdisanti
approved these changes
Aug 16, 2022
This is because the diff script is run inside the build Docker image. Another way you could approach this is have the execution of gradle from within the script set the environment variable. |
crisidev
approved these changes
Aug 16, 2022
unexge
force-pushed
the
unexge/hardcode-commit-in-version-for-pr-diffs
branch
from
14a40cb to
088ab65
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
After #1621 we started inserting codegen versions to generated packages. Those versions also include git commit hash and that causes PR Bot to generate diffs for every PR even when there are no changes in generated packages (example). In order to prevent that we want to have a fixed commit hash while generating diffs for generated packages.
Description
This PR allows overriding commit hash used in codegen versions via
SMITHY_RS_VERSION_COMMIT_HASH_OVERRIDEenv variable. We provide that value in PR Bot to fix commit hash used in PR Bot diffs.Testing
You can provide that env variable while generating packages to see whether codegen version is changed.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.