Reducing verbosity of various logs #3664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landonxjames
force-pushed
the
landonxjames/log-cleaning
branch
from
6613696
to
2c5a6bf
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
approved these changes
May 28, 2024
landonxjames
force-pushed
the
landonxjames/log-cleaning
branch
from
2c5a6bf
to
6109884
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
landonxjames
force-pushed
the
landonxjames/log-cleaning
branch
from
6109884
to
67236aa
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
approved these changes
May 29, 2024
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
aajtodd
reviewed
May 29, 2024
rust-runtime/aws-smithy-runtime-api/src/client/runtime_components.rs
Outdated
Show resolved
Hide resolved
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Removed the logging of the full IMDS Client struct Removed logging the Configbag in a couple places in RuntimeComponentsBuilder Removed logging of full ProvideCredentials objects and replaced with just their names Update CHANGELOG Removing extraneous comment
landonxjames
force-pushed
the
landonxjames/log-cleaning
branch
from
870ef21
to
2fdec71
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
aajtodd
approved these changes
May 30, 2024
rust-runtime/aws-smithy-runtime-api/src/client/runtime_components.rs
Outdated
Show resolved
Hide resolved
landonxjames
force-pushed
the
landonxjames/log-cleaning
branch
from
2fdec71
to
960c855
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Our logs had several entries that were extremely verbose and made them harder to sort through. This change aims to reduce the verbosity of those logs to something more manageable.
Description
Configbagin a couple places inRuntimeComponentsBuilderProvideCredentialsobjects in the CredentialsProviderChain` and replaced with just their namesThere are some verbose logs I did not remove because I was not sure of their usefulness. Most notably the
PartitionResolverstruct logs several hundred lines of region information each time it appears. Happy to truncate that as well if those logs aren't too helpful.Testing
This was tested locally by running the SDK logging example code with
RUST_LOG=traceprepended to thecargo runcommand. For comparison, when saved as a .txt file, the old logs take up2.8MBand the new logs take273KBfor the same operation.Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.