-
Notifications
You must be signed in to change notification settings - Fork 189
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reducing verbosity of various logs (#3664)
## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here --> Our logs had several entries that were extremely verbose and made them harder to sort through. This change aims to reduce the verbosity of those logs to something more manageable. ## Description <!--- Describe your changes in detail --> - Removed the logging of the full IMDS Client struct, replaced with a message that it was truncated - Removed logging the full `Configbag` in a couple places in `RuntimeComponentsBuilder` - Removed logging of full `ProvideCredentials` objects in the CredentialsProviderChain` and replaced with just their names There are some verbose logs I did not remove because I was not sure of their usefulness. Most notably the `PartitionResolver` struct logs several hundred lines of region information each time it appears. Happy to truncate that as well if those logs aren't too helpful. ## Testing <!--- Please describe in detail how you tested your changes --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> This was tested locally by running the SDK [logging example](https://docs.aws.amazon.com/sdk-for-rust/latest/dg/logging.html) code with `RUST_LOG=trace` prepended to the `cargo run` command. For comparison, when saved as a .txt file, the old logs take up `2.8MB` and the new logs take `273KB` for the same operation. ## Checklist <!--- If a checkbox below is not applicable, then please DELETE it rather than leaving it unchecked --> - [x] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
- Loading branch information
1 parent
a76dc18
commit 50c825b
Showing
6 changed files
with
35 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
[package] | ||
name = "aws-config" | ||
version = "1.5.0" | ||
version = "1.5.1" | ||
authors = [ | ||
"AWS Rust SDK Team <[email protected]>", | ||
"Russell Cohen <[email protected]>", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
[package] | ||
name = "aws-smithy-runtime-api" | ||
version = "1.6.1" | ||
version = "1.6.2" | ||
authors = ["AWS Rust SDK Team <[email protected]>", "Zelda Hessler <[email protected]>"] | ||
description = "Smithy runtime types." | ||
edition = "2021" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters