Bumping version of wasi crate dependency
#3476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.12.0 suffered from a bug the could impact users using lower versions of wit-bindgen dependencies. Mixed versions of wit-bindgen generated bindings in a single project would cause a symbol collision. This is fixed by newer versions of wit-bindgen and wasi 0.12.1 contains bindings generated by one of these newer versions. See issue below for details: bytecodealliance/wit-bindgen#849 Update CHANGELOG
landonxjames
force-pushed
the
wasi-ver-bump
branch
from
f0c02a7
to
03ca066
Compare
jdisanti
reviewed
Mar 12, 2024
jdisanti
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The
0.12.0version ofwasisuffered from a bug the could impact users using lower versions ofwit-bindgendependencies. Mixed versions ofwit-bindgengenerated bindings in a single project would cause a symbol collision. This is fixed by newer versions ofwit-bindgenandwasi = 0.12.1contains bindings generated by one of these newer versions. See this issue for details: bytecodealliance/wit-bindgen#849 and a longer discussion of the issue on Zulip here.Description
Bumped version of
wasidependency inaws-amithy-wasmfrom0.12.0->0.12.1Testing
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.