Skip to content

Commit

Permalink
Bumping version of wasi crate dependency (#3476)
Browse files Browse the repository at this point in the history
## Motivation and Context
The `0.12.0` version of `wasi` suffered from a bug the could impact
users using lower versions of `wit-bindgen` dependencies. Mixed versions
of `wit-bindgen` generated bindings in a single project would cause a
symbol collision. This is fixed by newer versions of `wit-bindgen` and
`wasi = 0.12.1` contains bindings generated by one of these newer
versions. See this issue for details:
bytecodealliance/wit-bindgen#849 and a longer
discussion of the issue on Zulip
[here](https://bytecodealliance.zulipchat.com/#narrow/stream/327223-wit-bindgen/topic/Component.20failing.20to.20compile.20with.20mixed.20wit-bindgen.20versions/near/422068264).

## Description
<!--- Describe your changes in detail -->
Bumped version of `wasi` dependency in `aws-amithy-wasm` from `0.12.0`
-> `0.12.1`

## Testing
<!--- Please describe in detail how you tested your changes -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->

## Checklist
<!--- If a checkbox below is not applicable, then please DELETE it
rather than leaving it unchecked -->
- [X] I have updated `CHANGELOG.next.toml` if I made changes to the
smithy-rs codegen or runtime crates


----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

---------

Co-authored-by: John DiSanti <[email protected]>
  • Loading branch information
landonxjames and jdisanti authored Mar 12, 2024
1 parent 3180295 commit 1e55d75
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
8 changes: 7 additions & 1 deletion CHANGELOG.next.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,10 @@
# message = "Fix typos in module documentation for generated crates"
# references = ["smithy-rs#920"]
# meta = { "breaking" = false, "tada" = false, "bug" = false, "target" = "client | server | all"}
# author = "rcoh"
# author = "rcoh"

[[smithy-rs]]
message = "Increased minimum version of wasi crate dependency in aws-smithy-wasm to 0.12.1."
references = ["smithy-rs#3476"]
meta = { "breaking" = false, "tada" = false, "bug" = false }
authors = ["landonxjames"]
4 changes: 2 additions & 2 deletions rust-runtime/aws-smithy-wasm/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "aws-smithy-wasm"
version = "0.1.0"
version = "0.1.1"
authors = [
"AWS Rust SDK Team <[email protected]>",
"Eduardo Rodrigues <[email protected]>",
Expand All @@ -19,7 +19,7 @@ http = "1.0.0"
tracing = "0.1.40"
# Note the wasi crate will only build for target wasm32-wasi, but having a target
# statement here breaks some of the CI tests, so we leave it with the rest of the deps
wasi = "0.12.0" # This is build on wasi-0.2.0
wasi = "0.12.1" # This is build on wasi-0.2.0

[package.metadata.docs.rs]
all-features = true
Expand Down

0 comments on commit 1e55d75

Please sign in to comment.