-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Credentials are loaded once for each client #3427
Comments
This was referenced Apr 2, 2024
github-merge-queue bot
pushed a commit
that referenced
this issue
Apr 9, 2024
## Motivation and Context Original issue: #3427 See the motivation section of the RFC. ## Description Proposes a new RFC that changes the default behavior of `SdkConfig` and `SharedCredentialsProvider`/`SharedTokenProvider` w.r.t caching and cache partitions. _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
github-merge-queue bot
pushed a commit
that referenced
this issue
Apr 10, 2024
## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here --> Original issue: #3427 RFC: #3544 ## Description <!--- Describe your changes in detail --> Fixes the `SharedCredentialsProvider` and `SharedTokenProvider` to re-use a consistent cache partition by default. `SdkConfig` does not create an identity cache by default still, that will need to be a follow on PR that gates it behind a new behavior version. Ideally we do that with the stalled stream protection work in #3527 ## Testing <!--- Please describe in detail how you tested your changes --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> Added new unit and integration tests. ## Checklist <!--- If a checkbox below is not applicable, then please DELETE it rather than leaving it unchecked --> - [X] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
1 task
This was fixed in the April 12th release. |
Well to be clear it is now possible, you still have to pass an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Each
IdentityResolver
that is created has its ownIdentityPartitionCacheKey
. This means that we hit separate caches. We need to create the identity resolver inSdkConfig
as part of the call tobuild()
.e.g:
Logs:
The text was updated successfully, but these errors were encountered: