Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ring to 0.17 #3112

Closed
fgaz opened this issue Oct 30, 2023 · 1 comment · Fixed by #3116
Closed

Update ring to 0.17 #3112

fgaz opened this issue Oct 30, 2023 · 1 comment · Fixed by #3116

Comments

@fgaz
Copy link

fgaz commented Oct 30, 2023 •
edited
Loading

I'm trying to build (a crate that depends on) the aws-config crate on risc-v, and ring 0.16 fails to build, while 0.17 builds fine. Could you update it to 0.17?
@jdisanti jdisanti mentioned this issue Oct 30, 2023
Merged
@jdisanti
Copy link
Collaborator

Thanks for informing us of this new version. I posted #3116 to upgrade to it.

github-merge-queue bot pushed a commit that referenced this issue Oct 31, 2023
@jdisanti
Upgrade ring to 0.17.5 (#3116)
1ae4d19 
Fixes #3112.

I opted to upgrade to the latest 0.17.5 in spite of the guidance in
[RFC-21](https://github.com/awslabs/smithy-rs/blob/main/design/src/rfcs/rfc0021_dependency_versions.md)
since this is a security critical dependency, and the maintainer has
aggressively yanked old versions in the past.

Note: ring 0.16 is still pulled in by rcgen as a dev dependency in
aws-smithy-http-server-python after these changes. The rcgen crate
hasn't upgraded yet.

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
rcoh pushed a commit that referenced this issue Nov 1, 2023
@jdisanti @rcoh
Upgrade ring to 0.17.5 (#3116)
9939bf9 
Fixes #3112.

I opted to upgrade to the latest 0.17.5 in spite of the guidance in
[RFC-21](https://github.com/awslabs/smithy-rs/blob/main/design/src/rfcs/rfc0021_dependency_versions.md)
since this is a security critical dependency, and the maintainer has
aggressively yanked old versions in the past.

Note: ring 0.16 is still pulled in by rcgen as a dev dependency in
aws-smithy-http-server-python after these changes. The rcgen crate
hasn't upgraded yet.

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade ring to 0.17.5 smithy-lang/smithy-rs
2 participants
@jdisanti @fgaz