Fix re-export of SdkError
#2931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdisanti
force-pushed
the
jdisanti-fix-sdkerror-reexport
branch
from
9605963 to
4a126b7
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
approved these changes
Aug 18, 2023
jdisanti
force-pushed
the
jdisanti-fix-sdkerror-reexport
branch
from
69fd3ba to
70c328f
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
…disanti-fix-sdkerror-reexport
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
It looks like this fixes the examples, but a change to aws-doc-sdk-examples needs to get merged before this can: awsdocs/aws-doc-sdk-examples#5286 |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SdkErrorwas re-exported in generated crates with the wrong generic argument for the response type, which causes the SDK examples to fail to compile. The example breaks weren't caught due to a bug in the CI script that checks them, addressed in smithy-rs#2930.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.