Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples don't compile #875

Closed
jdisanti opened this issue Aug 18, 2023 · 3 comments
Closed

Examples don't compile #875

jdisanti opened this issue Aug 18, 2023 · 3 comments
Assignees
@jdisanti
Labels
bug This issue is a bug. p0 This issue is the highest priority

Comments

@jdisanti
Copy link
Contributor

jdisanti commented Aug 18, 2023 •
edited
Loading

It looks like the examples are not compiling due to a change in the second generic argument to SdkError. This issue tracks fixing the examples, and also determining why this wasn't caught by CI or the release process.
@jdisanti jdisanti added bug This issue is a bug. p0 This issue is the highest priority labels Aug 18, 2023
@jdisanti jdisanti changed the title IAM examples don't compile Examples don't compile Aug 18, 2023
@jdisanti jdisanti self-assigned this Aug 18, 2023
@jdisanti
Copy link
Contributor Author

jdisanti commented Aug 18, 2023 •
edited
Loading

Fixes in progress:
smithy-lang/smithy-rs#2931
smithy-lang/smithy-rs#2930
awsdocs/aws-doc-sdk-examples#5286

@jdisanti
Copy link
Contributor Author

This has been fixed with the August 23rd release.

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdisanti jdisanti

Labels
bug This issue is a bug. p0 This issue is the highest priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jdisanti