Fix generation of constrained shapes reaching @sensitive shapes

Constrained shapes should always be able to `#[derive(Debug)]`. Fixes #2582.
smithy-lang · Apr 17, 2023 · bea4029 · bea4029
1 parent fc63800
commit bea4029
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 0 deletions.
diff --git a/CHANGELOG.next.toml b/CHANGELOG.next.toml
@@ -116,3 +116,9 @@ message = "`aws_smithy_types::date_time::Format` has been re-exported in service
 references = ["smithy-rs#2534"]
 meta = { "breaking" = false, "tada" = false, "bug" = false, "target" = "client" }
 author = "ysaito1001"
+
+[[smithy-rs]]
+message = "Fix generation of constrained shapes reaching `@sensitive` shapes"
+references = ["smithy-rs#2582", "smithy-rs#2585"]
+meta = { "breaking" = false, "tada" = false, "bug" = true, "target" = "server" }
+author = "david-perez"
diff --git a/codegen-core/common-test-models/constraints.smithy b/codegen-core/common-test-models/constraints.smithy
@@ -454,6 +454,7 @@ structure ConA {
 
     conBList: ConBList,
     lengthList: LengthList,
+    sensitiveLengthList: SensitiveLengthList,
 
     conBSet: ConBSet,
 
@@ -866,6 +867,14 @@ list LengthList {
     member: String
 }
 
+@length(max: 69)
+list SensitiveLengthList {
+    member: SensitiveStructure
+}
+
+@sensitive
+structure SensitiveStructure { }
+
 set ConBSet {
     member: ConBSetInner
 }

diff --git a/...ftware/amazon/smithy/rust/codegen/server/smithy/ConstrainedShapeSymbolMetadataProvider.kt b/...ftware/amazon/smithy/rust/codegen/server/smithy/ConstrainedShapeSymbolMetadataProvider.kt
@@ -16,6 +16,7 @@ import software.amazon.smithy.model.shapes.StructureShape
 import software.amazon.smithy.model.shapes.UnionShape
 import software.amazon.smithy.rust.codegen.core.rustlang.RustMetadata
 import software.amazon.smithy.rust.codegen.core.rustlang.Visibility
+import software.amazon.smithy.rust.codegen.core.smithy.RuntimeType
 import software.amazon.smithy.rust.codegen.core.smithy.RustSymbolProvider
 import software.amazon.smithy.rust.codegen.core.smithy.SymbolMetadataProvider
 import software.amazon.smithy.rust.codegen.core.smithy.containerDefaultMetadata
@@ -47,6 +48,11 @@ class ConstrainedShapeSymbolMetadataProvider(
             derives += containerDefaultMetadata(shape, model).derives
         }
 
+        // We should _always_ be able to `#[derive(Debug)]`: all constrained shapes' types are simply tuple newtypes
+        // wrapping a single type which always implements `Debug`.
+        // The wrapped type may not _derive_ `Debug` though, hence why this line is required; see https://github.com/awslabs/smithy-rs/issues/2582.
+        derives += RuntimeType.Debug
+
         val visibility = Visibility.publicIf(constrainedTypes, Visibility.PUBCRATE)
         return RustMetadata(derives, additionalAttributes, visibility)
     }