CR feedback II

smithy-lang · Dec 1, 2022 · 6c959cf · 6c959cf
1 parent f6bc5c2
commit 6c959cf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/...software/amazon/smithy/rust/codegen/client/smithy/endpoint/ClientContextParamDecorator.kt b/...software/amazon/smithy/rust/codegen/client/smithy/endpoint/ClientContextParamDecorator.kt
@@ -89,7 +89,7 @@ internal class ClientContextDecorator(ctx: CodegenContext) : ConfigCustomization
                     docsOrFallback(param.docs)
                     rust(
                         """
-                        pub fn set_${param.name}(mut self, ${param.name}: Option<#T>) -> Self {
+                        pub fn set_${param.name}(&mut self, ${param.name}: Option<#T>) -> &mut Self {
                             self.${param.name} = ${param.name};
                             self
                         }

diff --git a/codegen-core/src/main/kotlin/software/amazon/smithy/rust/codegen/core/testutil/Rust.kt b/codegen-core/src/main/kotlin/software/amazon/smithy/rust/codegen/core/testutil/Rust.kt
@@ -87,7 +87,8 @@ object TestWorkspace {
             )
             newProject.resolve("rust-toolchain.toml").writeText(
                 // help rust select the right version when we run cargo test
-                // TODO(cleanup): load this from the msrv property using a method like we do for runtime crate versions
+                // TODO(https://github.com/awslabs/smithy-rs/issues/2048): load this from the msrv property using a
+                //  method as we do for runtime crate versions
                 "[toolchain]\nchannel = \"1.62.1\"\n",
             )
             // ensure there at least an empty lib.rs file to avoid broken crates