use sdkId if available for service client generation #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aajtodd
approved these changes
Apr 15, 2021
| @@ -125,7 +125,7 @@ class ServiceGenerator(private val ctx: RenderingContext<ServiceShape>) { | |||
| writer.write("") | |||
| .write("override val serviceName: String") | |||
| .indent() | |||
| .write("get() = \"#L\"", service.id.name) | |||
| .write("get() = \"#L\"", ctx.settings.sdkId) | |||
There was a problem hiding this comment.
nit
this could be updated to just #S instead of a manual escape (I'm guessing I didn't know about the S format specifier when this was originally written).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use settings property to retrieve sdk id or service name. Fixes #236.
Issue #, if available: #236
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.