feat: standardize format, to make examining diffs easier

smithy-lang · Apr 12, 2024 · 0ba1f82 · 0ba1f82
1 parent f94b9a8
commit 0ba1f82
Show file tree

Hide file tree

Showing 214 changed files with 78,874 additions and 60,839 deletions.
diff --git a/.github/workflows/format.yml b/.github/workflows/format.yml
@@ -0,0 +1,12 @@
+# This workflow runs for every pull request
+name: Java Format Check
+
+on:
+  pull_request:
+
+jobs:
+  check-java:
+      - name: Check format of Java, md and yaml
+        shell: bash
+        run: |
+          make format_java_misc-check
diff --git a/.github/workflows/manual.yml b/.github/workflows/manual.yml
@@ -7,7 +7,7 @@ on:
   workflow_dispatch:
     inputs:
       dafny:
-        description: 'The Dafny version to use'
+        description: "The Dafny version to use"
         required: true
         type: string
 
@@ -27,4 +27,4 @@ jobs:
   manual-ci-rust:
     uses: ./.github/workflows/test_models_rust_tests.yml
     with:
-      dafny: ${{ inputs.dafny }}
+      dafny: ${{ inputs.dafny }}
diff --git a/.github/workflows/nightly_dafny.yml b/.github/workflows/nightly_dafny.yml
@@ -16,26 +16,32 @@ jobs:
     if: github.event_name != 'schedule' || github.repository_owner == 'smithy-lang'
     uses: ./.github/workflows/test_models_dafny_verification.yml
     with:
-      dafny: 'nightly-latest'
+      dafny: "nightly-latest"
   dafny-nightly-java:
     if: github.event_name != 'schedule' || github.repository_owner == 'smithy-lang'
     uses: ./.github/workflows/test_models_java_tests.yml
     with:
-      dafny: 'nightly-latest'
+      dafny: "nightly-latest"
   dafny-nightly-net:
     if: github.event_name != 'schedule' || github.repository_owner == 'smithy-lang'
     uses: ./.github/workflows/test_models_net_tests.yml
     with:
-      dafny: 'nightly-latest'
+      dafny: "nightly-latest"
   dafny-nightly-rust:
     if: github.event_name != 'schedule' || github.repository_owner == 'smithy-lang'
     uses: ./.github/workflows/test_models_rust_tests.yml
     with:
-      dafny: 'nightly-latest'
+      dafny: "nightly-latest"
 
   cut-issue-on-failure:
     runs-on: ubuntu-latest
-    needs: [dafny-nightly-verification, dafny-nightly-java, dafny-nightly-net, dafny-nightly-rust]
+    needs:
+      [
+        dafny-nightly-verification,
+        dafny-nightly-java,
+        dafny-nightly-net,
+        dafny-nightly-rust,
+      ]
     if: ${{ always() && contains(needs.*.result, 'failure') }}
     env:
       GH_TOKEN: ${{ secrets.CI_TOKEN }}

diff --git a/.github/workflows/pull.yml b/.github/workflows/pull.yml
@@ -8,12 +8,12 @@ jobs:
   pr-populate-dafny-versions:
     runs-on: ubuntu-latest
     steps:
-    - name: Populate Dafny versions list
-      id: populate-dafny-versions-list
-      run: echo "dafny-versions-list=['4.2.0', '4.4.0']" >> $GITHUB_OUTPUT
+      - name: Populate Dafny versions list
+        id: populate-dafny-versions-list
+        run: echo "dafny-versions-list=['4.2.0', '4.4.0']" >> $GITHUB_OUTPUT
     outputs:
       dafny-version-list: ${{ steps.populate-dafny-versions-list.outputs.dafny-versions-list }}
-        
+
   pr-ci-verification:
     needs: pr-populate-dafny-versions
     strategy:

diff --git a/.github/workflows/push.yml b/.github/workflows/push.yml
@@ -4,18 +4,18 @@ name: Push CI
 on:
   push:
     branches:
-      - main-1.x    
+      - main-1.x
 
 jobs:
   pr-populate-dafny-versions:
     runs-on: ubuntu-latest
     steps:
-    - name: Populate Dafny versions list
-      id: populate-dafny-versions-list
-      run: echo "dafny-versions-list=['4.2.0', '4.4.0']" >> $GITHUB_OUTPUT
+      - name: Populate Dafny versions list
+        id: populate-dafny-versions-list
+        run: echo "dafny-versions-list=['4.2.0', '4.4.0']" >> $GITHUB_OUTPUT
     outputs:
       dafny-version-list: ${{ steps.populate-dafny-versions-list.outputs.dafny-versions-list }}
-        
+
   push-ci-verification:
     needs: pr-populate-dafny-versions
     strategy:
@@ -54,4 +54,4 @@ jobs:
           - dafny-version: 4.2.0
     uses: ./.github/workflows/test_models_rust_tests.yml
     with:
-      dafny: ${{ matrix.dafny-version }}
+      dafny: ${{ matrix.dafny-version }}
diff --git a/.github/workflows/smithy-dafny-conversion.yml b/.github/workflows/smithy-dafny-conversion.yml
@@ -1,6 +1,6 @@
 name: smithy-dafny-conversion workflows
 
-on: 
+on:
   pull_request:
   push:
     branches:
@@ -13,8 +13,8 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-java@v3
         with:
-          distribution: 'corretto'
-          java-version: '8'
+          distribution: "corretto"
+          java-version: "8"
 
       - name: Setup Dafny
         uses: dafny-lang/[email protected]

diff --git a/.github/workflows/smithy-polymorph.yml b/.github/workflows/smithy-polymorph.yml
@@ -1,6 +1,6 @@
 name: smithy-dafny-codegen-cli workflows
 
-on: 
+on:
   pull_request:
   push:
     branches:
@@ -13,18 +13,18 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-java@v3
         with:
-          distribution: 'corretto'
-          java-version: '17'
+          distribution: "corretto"
+          java-version: "17"
       - uses: actions/setup-java@v3
         with:
-          distribution: 'corretto'
-          java-version: '17'
+          distribution: "corretto"
+          java-version: "17"
       - name: Setup Dafny
         uses: dafny-lang/[email protected]
         with:
           # Matching the hard-coded version for the "2023" edition for now
           dafny-version: 4.1.0
-  
+
       - name: Execute smithy-dafny-codegen-cli tests
         uses: gradle/gradle-build-action@v2
         with:

diff --git a/.github/workflows/test_models_dafny_verification.yml b/.github/workflows/test_models_dafny_verification.yml
@@ -5,7 +5,7 @@ on:
   workflow_call:
     inputs:
       dafny:
-        description: 'The Dafny version to run'
+        description: "The Dafny version to run"
         required: true
         type: string
 
@@ -14,44 +14,44 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        dafny-version: 
+        dafny-version:
           - ${{ inputs.dafny }}
         library: [
-          TestModels/dafny-dependencies/StandardLibrary, # This stores current Polymorph dependencies that all TestModels depend on
-          TestModels/Aggregate,
-          TestModels/AggregateReferences,
-          TestModels/CodegenPatches,
-          TestModels/Constraints,
-          TestModels/Constructor,
-          TestModels/Dependencies,
-          TestModels/Errors,
-          TestModels/Extendable,
-          TestModels/Extern,
-          # TestModels/LanguageSpecificLogic, # requires >4.4.0
-          TestModels/LocalService,
-          TestModels/MultipleModels,
-          TestModels/Refinement,
-          TestModels/Resource,
-          # TestModels/SimpleTypes/BigDecimal,
-          # TestModels/SimpleTypes/BigInteger,
-          TestModels/SimpleTypes/SimpleBlob,
-          TestModels/SimpleTypes/SimpleBoolean,
-          # TestModels/SimpleTypes/SimpleByte,
-          TestModels/SimpleTypes/SimpleDouble,          
-          TestModels/SimpleTypes/SimpleEnum,
-          # TestModels/SimpleTypes/SimpleEnumV2,
-          # TestModels/SimpleTypes/SimpleFloat,
-          TestModels/SimpleTypes/SimpleInteger,
-          TestModels/SimpleTypes/SimpleLong,
-          # TestModels/SimpleTypes/SimpleShort,
-          TestModels/SimpleTypes/SimpleString,
-          # TestModels/SimpleTypes/SimpleTimestamp,
-          TestModels/Union,
-          TestModels/aws-sdks/ddb,
-          TestModels/aws-sdks/kms,
-          TestModels/aws-sdks/sqs-via-cli,
-        ]
-        os: [ ubuntu-latest ]
+            TestModels/dafny-dependencies/StandardLibrary, # This stores current Polymorph dependencies that all TestModels depend on
+            TestModels/Aggregate,
+            TestModels/AggregateReferences,
+            TestModels/CodegenPatches,
+            TestModels/Constraints,
+            TestModels/Constructor,
+            TestModels/Dependencies,
+            TestModels/Errors,
+            TestModels/Extendable,
+            TestModels/Extern,
+            # TestModels/LanguageSpecificLogic, # requires >4.4.0
+            TestModels/LocalService,
+            TestModels/MultipleModels,
+            TestModels/Refinement,
+            TestModels/Resource,
+            # TestModels/SimpleTypes/BigDecimal,
+            # TestModels/SimpleTypes/BigInteger,
+            TestModels/SimpleTypes/SimpleBlob,
+            TestModels/SimpleTypes/SimpleBoolean,
+            # TestModels/SimpleTypes/SimpleByte,
+            TestModels/SimpleTypes/SimpleDouble,
+            TestModels/SimpleTypes/SimpleEnum,
+            # TestModels/SimpleTypes/SimpleEnumV2,
+            # TestModels/SimpleTypes/SimpleFloat,
+            TestModels/SimpleTypes/SimpleInteger,
+            TestModels/SimpleTypes/SimpleLong,
+            # TestModels/SimpleTypes/SimpleShort,
+            TestModels/SimpleTypes/SimpleString,
+            # TestModels/SimpleTypes/SimpleTimestamp,
+            TestModels/Union,
+            TestModels/aws-sdks/ddb,
+            TestModels/aws-sdks/kms,
+            TestModels/aws-sdks/sqs-via-cli,
+          ]
+        os: [ubuntu-latest]
         include:
           # One-offs until TestModels migrate to 4.4.0
           - library: TestModels/LanguageSpecificLogic

diff --git a/.github/workflows/test_models_java_tests.yml b/.github/workflows/test_models_java_tests.yml
@@ -5,7 +5,7 @@ on:
   workflow_call:
     inputs:
       dafny:
-        description: 'The Dafny version to run'
+        description: "The Dafny version to run"
         required: true
         type: string
 
@@ -15,39 +15,39 @@ jobs:
       fail-fast: false
       matrix:
         library: [
-          TestModels/dafny-dependencies/StandardLibrary, # This stores current Polymorph dependencies that all TestModels depend on
-          # TestModels/Aggregate,
-          # TestModels/AggregateReferences,
-          TestModels/CodegenPatches,
-          TestModels/Constraints,
-          # TestModels/Constructor,
-          # TestModels/Dependencies,
-          TestModels/Errors,
-          TestModels/Extendable,
-          # TestModels/Extern,
-          # TestModels/LanguageSpecificLogic,
-          TestModels/LocalService,
-          TestModels/MultipleModels,
-          # TestModels/Refinement,
-          TestModels/Resource,
-          # TestModels/SimpleTypes/BigDecimal,
-          # TestModels/SimpleTypes/BigInteger,
-          # TestModels/SimpleTypes/SimpleBlob,
-          # TestModels/SimpleTypes/SimpleBoolean,
-          # TestModels/SimpleTypes/SimpleByte,
-          # TestModels/SimpleTypes/SimpleDouble,
-          # TestModels/SimpleTypes/SimpleEnum,
-          # TestModels/SimpleTypes/SimpleEnumV2,
-          # TestModels/SimpleTypes/SimpleFloat,
-          # TestModels/SimpleTypes/SimpleInteger,
-          # TestModels/SimpleTypes/SimpleLong,
-          # TestModels/SimpleTypes/SimpleShort,
-          # TestModels/SimpleTypes/SimpleString,
-          # TestModels/SimpleTypes/SimpleTimestamp,
-          # TestModels/Union,
-          TestModels/aws-sdks/ddb,
-          TestModels/aws-sdks/kms,
-        ]
+            TestModels/dafny-dependencies/StandardLibrary, # This stores current Polymorph dependencies that all TestModels depend on
+            # TestModels/Aggregate,
+            # TestModels/AggregateReferences,
+            TestModels/CodegenPatches,
+            TestModels/Constraints,
+            # TestModels/Constructor,
+            # TestModels/Dependencies,
+            TestModels/Errors,
+            TestModels/Extendable,
+            # TestModels/Extern,
+            # TestModels/LanguageSpecificLogic,
+            TestModels/LocalService,
+            TestModels/MultipleModels,
+            # TestModels/Refinement,
+            TestModels/Resource,
+            # TestModels/SimpleTypes/BigDecimal,
+            # TestModels/SimpleTypes/BigInteger,
+            # TestModels/SimpleTypes/SimpleBlob,
+            # TestModels/SimpleTypes/SimpleBoolean,
+            # TestModels/SimpleTypes/SimpleByte,
+            # TestModels/SimpleTypes/SimpleDouble,
+            # TestModels/SimpleTypes/SimpleEnum,
+            # TestModels/SimpleTypes/SimpleEnumV2,
+            # TestModels/SimpleTypes/SimpleFloat,
+            # TestModels/SimpleTypes/SimpleInteger,
+            # TestModels/SimpleTypes/SimpleLong,
+            # TestModels/SimpleTypes/SimpleShort,
+            # TestModels/SimpleTypes/SimpleString,
+            # TestModels/SimpleTypes/SimpleTimestamp,
+            # TestModels/Union,
+            TestModels/aws-sdks/ddb,
+            TestModels/aws-sdks/kms,
+          ]
     runs-on: "ubuntu-latest"
     permissions:
       id-token: write
@@ -74,10 +74,10 @@ jobs:
         with:
           dafny-version: ${{ inputs.dafny }}
 
-      - name: Setup Java 
+      - name: Setup Java
         uses: actions/setup-java@v3
         with:
-          distribution: 'corretto'
+          distribution: "corretto"
           java-version: 17
 
       - name: Setup smithy-dafny-conversion
@@ -89,14 +89,14 @@ jobs:
       - name: Setup Java 17 for codegen
         uses: actions/setup-java@v3
         with:
-          distribution: 'corretto'
-          java-version: '17'
+          distribution: "corretto"
+          java-version: "17"
 
       - name: Setup dependencies
         working-directory: ./${{ matrix.library }}
         run: |
           make setup_prettier
-  
+
       - name: Generate Polymorph Dafny and Java code
         shell: bash
         working-directory: ./${{ matrix.library }}
@@ -108,8 +108,8 @@ jobs:
       - name: Setup Java 8 for running tests
         uses: actions/setup-java@v3
         with:
-          distribution: 'corretto'
-          java-version: '8'
+          distribution: "corretto"
+          java-version: "8"
 
       - name: Compile ${{ matrix.library }} implementation
         shell: bash