-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure Tests Work for SSP #95
Comments
Many of the tests pass in functions as arguments using '@' for function handling. This creates an issue since for instance in SSA_RFEMSliceTester.m:
Therefore, a solution like the one provided at the following link may be an option: https://www.mathworks.com/matlabcentral/answers/97571-how-do-i-specify-an-absolute-pathname-for-a-function-when-using-str2func-to-capture-its-handle. Edit: Also a problem for SSA_MPSliceTester. |
Update: such an implementation will not work, since the function that is passed in will expect arguments to be passed into the function right away (i.e. when it's passed in as an argument) as well, which is not possible since the arguments to pass into the passed in function are determined in a separate testing file. For now, will continue to work on #92 as if SSA_MPSliceTester.m and SSA_RFEMSliceTester.m were fixed. (Keeping in mind that SSA_MPSliceTester resulted in segmentation violation before the file standardization task and that SSA_RFEMSliceTester produces a multitude of warnings of the following nature
before the standardization task as well, this issue can close upon getting these results). |
Matlab can be tricky to work with for tasks such as this. If you can get it to work with the tests in a separate folder, that would be great, but if we have to change the file structure to something simpler, that is a viable option. Some thoughts that come to mind for dealing with the matlab headaches is to play with the matlab path environment variables. There may be a way to tell it to search the folder you want it to search. Another option might be to create symbolic links to the files that you need. This isn't a pretty option, and I don't think it would be easy to maintain. |
This issue comes up from implementation of #92 for SSP. The following tests need to be checked to see if running them results in the same results as before restructuring the folder and file structure:
SSA_InputSpecial.monly used by SSA_InputTesterSSA_Original_GenAlgNonCirc.mnot used by any testSSA_Original_RFEMSliceTester.monly used by SSA_RFEMSliceTesterSSA_Original_SliceTester.monly used by SSA_MPSliceTesterSSA_PropertySorterTester.mhas a different type of error (i.e.Undefined function or variable 'SlicerModule'.
)SSA_SliceTesterAlgorithm.monly used by SSA_MPSliceTester and SSA_RFEMSliceTesterThe text was updated successfully, but these errors were encountered: