-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SolarHeatingWaterOnly_SRS: Clarity Issue #59
Comments
@elwazana can you pull the text from the original and reproduce it in your issue? It will make it much faster to review. You can also assign issue like this to me. |
LC3: A9 - The model currently only accounts for charging of the tank. A more complete |
I guess it wasn't faster (in this case) to put the text together with the issue. 😄 You are correct that the charging terminology may not be familiar to all of the readers. How about: "LC3: A9 - The model currently only accounts for heating of the tank. That is, increasing the temperature of the water and the PCM to match the temperature of the coil. A more complete model would also account for cooling of the tank." Please also make this change in the Drasil code. |
In section 6, LC3 mentions the charging and discharging of the tank. However, it may make the sentence clearer by mentioning that this is in reference to the temperature of the tank, rather than leave it as ambiguous "charging/discharging".
The text was updated successfully, but these errors were encountered: