Skip to content

Commit

Permalink
Added Unlikely changes to noPCM example as per issue #100
Browse files Browse the repository at this point in the history
  • Loading branch information
@elwazana
elwazana committed Jun 20, 2018
1 parent 521248e commit f7da1ff
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
Binary file modified CaseStudies/noPCM/docs/SRS/SRS.pdf
View file
Binary file not shown.
12 changes: 12 additions & 0 deletions CaseStudies/noPCM/docs/SRS/SRS.tex
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
\usepackage{booktabs}
\usepackage{caption}
\usepackage{url}
\newcounter{ucnum}
\newcommand{\ltheucnum}{UC\theucnum}
\newcommand{\ucref}[1]{UC\ref{#1}}
%\usepackage{refcheck}

\hypersetup{
Expand Down Expand Up @@ -1545,6 +1548,15 @@ \section{Likely Changes}\label{sec_likelychgs}

\end{itemize}

\section{Unlikely Changes}
If changes were to be made with regards to the following, a different algorithm would be needed.

This comment has been minimized.

Sign in to view

Copy link
@smiths

smiths Jun 25, 2018

Owner

Algorithm isn't a good word here. This is about the requirements, not the design. For now, just delete this introductory sentence.

\begin{itemize}
\item[\refstepcounter{ucnum}\ltheucnum \label{UC_convCooling}:] Changes related to \aref{A_Newt_coil} are not possible due to the dependency of the calculations on the Heat Flux into the water from the coil.

This comment has been minimized.

Sign in to view

Copy link
@smiths

smiths Jun 25, 2018

Owner

Don't try to explain why the changes are unlikely (unless this is something that we can easily justify). Also, within a family of variabilities, we could change this. It is probably better to not consider changing the boundary conditions from Newton's law of cooling as an unlikely change.
\item[\refstepcounter{ucnum}\ltheucnum \label{UC_opRange}:] Changes related to \aref{A_OpRange} are not possible due to \iref{ewat} and \iref{I_HWAT} only applying if \aref{A_OpRange} is true.

This comment has been minimized.

Sign in to view

Copy link
@smiths

smiths Jun 25, 2018

Owner

You've picked a good assumption, but, again, your explanation is off. It actually would be easy to change the material from water and PCM to something else, as long as we knew the material properties. What wouldn't be easy is adding additional phase changes. The program assumes that the water never changes state and that the PCM only changes from solid to liquid. Having solid water (ice) or gaseous PCM is a phase change that the equations do not consider. Just say that the \aref{A_OpRange} is an unlikely change, since the phase change of the PCM from solid to liquid is the only phase change considered.

This comment has been minimized.

Sign in to view

Copy link
@elwazana

elwazana Jun 25, 2018

Author Collaborator

@smiths Hello Dr. Smith, this is for the no PCM example, in that case, should I just completely remove this Unlikely change or just have it state that water in a solid state is never considered?

This comment has been minimized.

Sign in to view

Copy link
@smiths

smiths Jun 25, 2018

Owner

You are right that I was thinking the PCM example. For noPCM you can still keep this unlikely change, just modify it. It is an unlikely change that the water will change state from the liquid state. This is actually a good example. The noPCM example has nothing about phase change in the SRS or in the code. Adding this change would really be a whole new problem.

This comment has been minimized.

Sign in to view

Copy link
@elwazana

elwazana Jun 25, 2018

Author Collaborator

@smiths Should I doc similar changes to the unlikely changes of the PCM example? Also, there are a few additional unlikely changes in that example, should I wait until those get reviewed by you separately?
\item[\refstepcounter{ucnum}\ltheucnum \label{UC_intHeat}:] For the derivation of \iref{ewat}, \aref{A_int_heat} must be held as true.

This comment has been minimized.

Sign in to view

Copy link
@smiths

smiths Jun 25, 2018

Owner

Okay.
\end{itemize}

\bibliographystyle {plain}
\bibliography {PCM_SRS}

Expand Down

0 comments on commit f7da1ff

Please sign in to comment.