Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -B for BED input to gc_extrap #34

Merged
merged 1 commit into from
Mar 12, 2018

Conversation

nishill
Copy link
Contributor

@nishill nishill commented Mar 12, 2018

At the moment the -D switch on gc_extrap stands for both BED input and defect mode. No biggie, but it would be nice for them to have different representations.

Thanks,

@andrewdavidsmith
Copy link
Contributor

Looks great -- thanks very much @nishill Can you say if this requires a change to the documentation at the same time? Or did they already assume B for BED?

@nishill
Copy link
Contributor Author

nishill commented Mar 12, 2018

No problem! I just checked the documentation now and it looks like the defect mode was left out of the docs for gc_extrap and the bed option is set to -D.

@timydaley timydaley merged commit 28961ca into smithlabcode:master Mar 12, 2018
@timydaley
Copy link
Contributor

Yup. It was a mistake on my part. Good catch nishill. Thank you very much for finding this. I guess no one had used gc_extrap with bed files and in defect mode, so the issue never came up.

@nishill
Copy link
Contributor Author

nishill commented Mar 12, 2018

Yeah, my use case may be fairly specific. I'm happy to help, thanks for the great software!

@timydaley
Copy link
Contributor

Thank you for using it. Feel free to send any questions, ideas, or even criticisms my way. Thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants