-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX Ensure constructors are populated in mocks of interfaces in PHP 8 #8
FIX Ensure constructors are populated in mocks of interfaces in PHP 8 #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but could involve less copy/pasta
cf5c6d8
to
da4e120
Compare
da4e120
to
a3114fc
Compare
Have added test coverage. |
For some reason this is failing with an undefined XDEBUG_CC_UNUSED constant being referenced on php 7.3, 7.4, and nightly |
1411795
to
43abf56
Compare
17c77f8
to
2c78a9a
Compare
2c78a9a
to
af2b323
Compare
I've looked into the failures: Xdebug 3 is now installed on builds running PHP 7.3 and laterXdebug 3 completely revised the available configuration options, throwing warnings when any old settings are set or accessed. This requires a change in the way Xdebug is configured (using php-token-stream outdatedThe (now deprecated) @sminnee Thoughts on how to proceed? We won't have any green builds on this repository (nor |
I'll close this for the time being - if down the road we decide to invest the unreasonable amount of effort required to get the builds green and continue maintaining this fork, the diff is here as a reference. |
See https://news-web.php.net/php.internals/109377
This is a legitimate issue caused by a change in PHP's behaviour, and was fixed upstream in PHPUnit 9, so it makes sense to implement the same patch here.
Fixes #7.