Introduce Compose Destinations for SDK Navigation #531
Conversation
jumaallan
force-pushed
the
feat/refactor-ui-components
branch
from
f5b930a to
60f92dd
Compare
| handle: SavedStateHandle, | ||
| ): T = when (modelClass) { | ||
| OrchestratedSelfieViewModel::class.java -> OrchestratedSelfieViewModel( | ||
| navArgs = OrchestratedSelfieCaptureScreenDestination.argsFrom( |
There was a problem hiding this comment.
Do we want to use this for only selfie capture? if yes fine, if not maybe this needs to be generic or have some sort of reusablity
| // jobId = jobId, | ||
| // allowAgentMode = allowAgentMode, | ||
| // showAttribution = showAttribution, | ||
| // showInstructions = showInstructions, |
There was a problem hiding this comment.
The direction generally makes sense to me. As discussed yesterday, let's sync up with @tobitech to define the interfaces and then we can implement this product by product. Great work @jumaallan - thanks for exploring this option.
| composeTestRule.onNodeWithText(subtitleText, substring = true).assertIsDisplayed() | ||
| composeTestRule.onNodeWithText(captureTitle, substring = true).assertIsDisplayed() | ||
| } | ||
| // |
There was a problem hiding this comment.
Just putting a comment here so we don't forget to fix the tests before we release this
| import com.smileidentity.util.randomJobId | ||
| import com.smileidentity.util.randomUserId | ||
| import com.smileidentity.viewmodel.BiometricKycViewModel | ||
| import com.smileidentity.viewmodel.viewModelFactory | ||
| import kotlinx.collections.immutable.ImmutableMap | ||
| import kotlinx.collections.immutable.persistentMapOf | ||
|
|
||
| @Destination<BiometricGraph>(start = true) | ||
| @Composable | ||
| internal fun OrchestratedSelfieCaptureScreengg() { |
There was a problem hiding this comment.
Should this call the OrchestratedSelfieCaptureScreen?
There was a problem hiding this comment.
Screen_Recording_20250219_121921_Smile.ID.mp4
Hey @jumaallan just a note on transitions and back press
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Story: https://app.shortcut.com/smileid/story/xxx
Summary
A few sentences/bullet points about the changes
Known Issues
Any shortcomings in your work. This may include corner cases not correctly handled or issues related
to but not within the scope of your PR. Design compromises should be discussed here if they were not
already discussed above.
Test Instructions
Concise test instructions on how to verify that your feature works as intended. This should include
changes to the development environment (if applicable) and all commands needed to run your work.
Screenshot
If applicable (e.g. UI changes), add screenshots to help explain your work.