Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/docflow #484

Merged
merged 5 commits into from
Nov 8, 2024
Merged

Bugfix/docflow #484

merged 5 commits into from
Nov 8, 2024

Conversation

JNdhlovu
Copy link
Contributor

@JNdhlovu JNdhlovu commented Nov 8, 2024

Story: https://app.shortcut.com/smileid/story/xxx

Summary

Fix for

  1. Enhanced doc v submitted as doc v
  2. Correct flow for selfie when showInstructions is false

Known Issues

N/A

Test Instructions

  1. Enhanced doc v should be submitted correctly as in the screenshot
  2. when show instructions is false on selfie it should correctly show capture screen
  3. doc v, enhanced doc v, biometric kyc should correctly observe point 2

Screenshot

NB: Tested with a keyboard image hence the failure
Screenshot 2024-11-08 at 12 53 18 PM

@JNdhlovu JNdhlovu requested a review from a team as a code owner November 8, 2024 11:21
@JNdhlovu JNdhlovu merged commit 1d2592c into main Nov 8, 2024
3 checks passed
@JNdhlovu JNdhlovu deleted the bugfix/docflow branch November 8, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobitech tobitech tobitech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JNdhlovu @tobitech