feat: add range slider with custom scale #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
automotiveengineeringbot
deployed
to
branch-components-pkg-feat-range-slider-with-scale
talamcol
approved these changes
Feb 12, 2024
| chartHeight={chartHeight} | ||
| {...rest} | ||
| /> | ||
| {facets ? ( |
There was a problem hiding this comment.
should be alright with typescript but couldn't this result in a state where both are present on the screen? If facets are undefined, rangeSliderScale should be present, no?
so: facets ? RangleSliderWithChart : RangeSliderWithScale should be enough?
automotiveengineeringbot
deployed
to
branch-components-pkg-feat-range-slider-with-scale
|
🎉 This PR is included in version 20.46.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References DM-2826
Motivation and context
Due to optimisation issue with histograms, we have decided to replace majority of histograms with range slider only.
This range slider need to have custom scale like we have for histograms.
Before
[Describe the current behavior and / or add a screenshot of the current state]
After
[Describe the new behavior and / or add a screenshot of the new state]
How to test
Check here https://feat-range-slider-filters-listings-web.branch.autoscout24.dev/de/s
[Add a deep link and instructions how to verify the new behavior]