Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (SST-989) extend email error page #1216

Merged
merged 6 commits into from
Nov 26, 2024

Conversation

lkappeler
Copy link
Contributor

References https://smg-au.atlassian.net/browse/SST-989

Motivation and context

  • Adds primary and secondary action to verify email page
  • Extends the back to login action to log out the user and redirect them back to login in case they have an active session with auth0

Before

Screenshot 2024-11-25 at 11 33 54

After

Screenshot 2024-11-25 at 11 33 58

How to test

Check the according component in the deployment
Note: For simplicity the links are relative on the error pages

@lkappeler lkappeler requested review from a team, Averethel, GutierrezGo and talamcol and removed request for a team November 25, 2024 10:36
@automotiveengineeringbot automotiveengineeringbot deployed to branch-components-pkg-lkappeler-sst-989-extend-email-error-page November 25, 2024 10:41 Active
@automotiveengineeringbot
Copy link
Collaborator

🎉 This PR is included in version 23.13.0-lkappeler-SST-989-extend-email-error-page-67ee30c795ff456af8972fe75bc8f9f1a995c1d3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

const loginLink = `/${languageToUse}/account/logon`;
const query = `?returnurl=${encodeURIComponent(loginLink)}`;
const loginWithLogoutLink = `${logoutLink}${query}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't it more a logoutWithLoginLink ? 😅

@automotiveengineeringbot automotiveengineeringbot deployed to branch-components-pkg-lkappeler-sst-989-extend-email-error-page November 26, 2024 13:31 Active
@automotiveengineeringbot
Copy link
Collaborator

🎉 This PR is included in version 23.13.0-lkappeler-SST-989-extend-email-error-page-99ec82a838ab5daa20290aee4f8a06bad160f364.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@automotiveengineeringbot automotiveengineeringbot deployed to branch-components-pkg-lkappeler-sst-989-extend-email-error-page November 26, 2024 13:49 Active
@automotiveengineeringbot
Copy link
Collaborator

🎉 This PR is included in version 23.14.0-lkappeler-SST-989-extend-email-error-page-da001b74821b90f3be07f78b142bf7646fa84fe6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@automotiveengineeringbot automotiveengineeringbot deployed to branch-components-pkg-lkappeler-sst-989-extend-email-error-page November 26, 2024 14:03 Active
@automotiveengineeringbot
Copy link
Collaborator

🎉 This PR is included in version 23.14.0-lkappeler-SST-989-extend-email-error-page-a9b6ca2bb12ab9cefaa9a81489b1ae86c7d0697d.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lkappeler lkappeler merged commit 9db80d3 into main Nov 26, 2024
12 checks passed
@lkappeler lkappeler deleted the lkappeler-SST-989-extend-email-error-page branch November 26, 2024 14:34
@automotiveengineeringbot
Copy link
Collaborator

🎉 This PR is included in version 23.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants