feat: add new icons for market price deviation #1212
Conversation
automotiveengineeringbot
deployed
to
branch-components-pkg-feat-new-market-price-deviation-icons
|
🎉 This PR is included in version 23.12.0-feat-new-market-price-deviation-icons-001b6b6f5af8c55b1082c703a4c2f86e8095e48a.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
automotiveengineeringbot
deployed
to
branch-components-pkg-feat-new-market-price-deviation-icons
|
🎉 This PR is included in version 23.12.0-feat-new-market-price-deviation-icons-df1ad0cbd2d2b1e302d8ea7fa232090265c9d76d.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
NenadRos
requested review from
a team,
GutierrezGo,
filip-kis-smg,
DejanBojovicSMG and
boyarskiy
and removed request for
a team
automotiveengineeringbot
deployed
to
branch-components-pkg-feat-new-market-price-deviation-icons
|
🎉 This PR is included in version 23.12.0-feat-new-market-price-deviation-icons-c3eaa2b9ea7c8348e14743c5c3fcdd0d4b2b01dc.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
There was a problem hiding this comment.
@NenadRos hey I approved the PR before you added the tiny icons. Is it possible to use the small ones that we already have in our library?
Then we will have 3 variations plus the double one, can you sync with the designers about this? Thank you
automotiveengineeringbot
deployed
to
branch-components-pkg-feat-new-market-price-deviation-icons
|
🎉 This PR is included in version 23.12.0-feat-new-market-price-deviation-icons-97a674ce8dfb8b57a0d968c95fe08d225eb93764.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
automotiveengineeringbot
deployed
to
branch-components-pkg-feat-new-market-price-deviation-icons
|
🎉 This PR is included in version 23.13.0-feat-new-market-price-deviation-icons-b5de52b597185daf6826899cd5501fba2dd23924.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
It is possible and I tried it when you approved it.
In the meantime I discovered
|
|
@NenadRos if you already checked with the designers and they need/want the tiny instead the small one that we already have, then go for it. Thank you for checking it 🌷 |
…hevron small icons
automotiveengineeringbot
deployed
to
branch-components-pkg-feat-new-market-price-deviation-icons
|
🎉 This PR is included in version 23.13.0-feat-new-market-price-deviation-icons-d10c381aec789b0b078a5bc43ff7230a2e7d7353.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
automotiveengineeringbot
deployed
to
branch-components-pkg-feat-new-market-price-deviation-icons
|
🎉 This PR is included in version 23.13.0-feat-new-market-price-deviation-icons-f28a2a363e31ce3e609e731671404bdebeed50ef.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Final decision (designer agreed):
|
|
@NenadRos thank you so much for checking with the Designer. We need to try to use what we have being consistent and unifying the designs. It is really nice to do not see big, small tiny for icons. Otherwise, we will face in the future so many icons for many sizes/styles 🚴🏼♂️ 🚴🏼♂️ |
|
🎉 This PR is included in version 23.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
References IN-2345
Motivation and context
We want to change existing icons for market price deviation.
Before
n/a
After