test: custom jest assertion for coordinate/bounds validation #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missinglink
force-pushed
the
bbox-validate
branch
from
f8745ee to
bf91f92
Compare
missinglink
force-pushed
the
bbox-validate
branch
from
bf91f92 to
8f00c6d
Compare
|
Looking great! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in #297 this PR makes the bounds assertions more consistent.
I ended up writing it in a custom jest assertion called
.toBeValidBounds()(there's also. toBeValidCoordinate()which is used internally but also exposed).The issue we discussed about the antimeridian etc. is a bit out-of-scope, I had a look around for a module which would validate it and couldn't find anything, I may end up writing one myself at some point...
resolves #297