Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: Geocode Earth #296

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Conversation

missinglink
Copy link
Collaborator

@missinglink missinglink commented Oct 8, 2021

as mentioned in #295, this PR adds the provider Geocode Earth which is an extension of the Pelias provider from that PR.

this PR is based on #295, so it's probably easiest to merge that first or just check out the second commit to see the diff.

@missinglink
Copy link
Collaborator Author

missinglink commented Oct 8, 2021

If someone from the maintainers team wants to sign up for a trial at https://geocode.earth, you can send me the email address used and I'll upgrade the account from a trial to a donation 🙇

That way you can create keys for GATSBY_GEOCODEEARTH_API_KEY without worrying about being charged.

@missinglink
Copy link
Collaborator Author

I plan to rebase this against #295 and clean it up before bringing it out of draft.

@smeijer do you know how I can get rid of this eslint error for the variable named api_key (which is inherited from the provider and can't be changed)?

Copy link
Owner

@smeijer smeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a suggestion to fix silence that camel case issue.

Also, feel free to list the new providers in README.md

docs/lib/providers.ts Outdated Show resolved Hide resolved
docs/lib/providers.ts Show resolved Hide resolved
@missinglink missinglink force-pushed the geocodeearth branch 4 times, most recently from d10a63e to 4b07c23 Compare October 12, 2021 05:25
@missinglink missinglink marked this pull request as ready for review October 12, 2021 05:25
@missinglink
Copy link
Collaborator Author

Cool this is ready to go, please feel free to ping me for a free FOSS account upgrade for the Gatsby key.

On a more personal note, we just recently landed this PR from a Dutch contributor to improve address parsing in 🇳🇱

@smeijer
Copy link
Owner

smeijer commented Oct 12, 2021

Thanks! Looking great!

I might ping you for that key when I have a bit more time at hand. 👍

@smeijer smeijer merged commit 14d9670 into smeijer:develop Oct 12, 2021
@smeijer
Copy link
Owner

smeijer commented Oct 12, 2021

I've published https://github.com/smeijer/leaflet-geosearch/releases/tag/v3.6.0, which includes this pull.

@missinglink
Copy link
Collaborator Author

Hi @smeijer I'd like to get the live demo working, is there anything I can do to help with that?

@smeijer
Copy link
Owner

smeijer commented Oct 18, 2021

Then I'd need that API key I think. If you have Twitter, that's by far the fasted way to reach me (@meijer_s), alternatively, you can find my email on my github profile.

That api key can be public right? Can you restrict it to the https://smeijer.github.io domain?

@missinglink
Copy link
Collaborator Author

I think its easiest if you sign up for an account and control it yourself (you can configure the domain after registering).
https://app.geocode.earth/users/sign_up

@smeijer
Copy link
Owner

smeijer commented Oct 18, 2021

geocode_earth now works, pelias does not.

@missinglink
Copy link
Collaborator Author

cool thanks, since Pelias is self-hosted we could either use the same api_key and host configuration as GeocodeEarth (as a sort of global demo) or leave it as-is where it returns no results for most people but works for developers running a local server.

eg it actually works fine for me because I have a local server running at http://localhost:4000/

Screenshot 2021-10-18 at 20 35 51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants