Revert "Reland "[Clang][SemaCXX] Add unused warning for variables declared in condition expressions"" #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lared in condition expressions"" This reverts commit 92023b1. Further issues were uncovered: - False positive -Wunused-variable on function-static variables with the used attribute. ClangBuiltLinux/linux#1926 A test case needs to be added for this. - Request for a new flag for these. https://reviews.llvm.org/D152495#4628877 https://reviews.llvm.org/D152495#4628887 [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This reverts commit 92023b1.
Further issues were uncovered:
used attribute. new instances of -Wunused-variable w/ clang-18 ClangBuiltLinux/linux#1926
A test case needs to be added for this.
https://reviews.llvm.org/D152495#4628877
https://reviews.llvm.org/D152495#4628887