Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A little fix to upload.py #16

Merged
merged 1 commit into from
May 18, 2017
Merged

Conversation

ZhilinS
Copy link
Contributor

@ZhilinS ZhilinS commented May 18, 2017

get_current_emoji_list function had a greedy quantifier in regexp: "data-emoji-name="(.*)""
I.e. for string like
data-emoji-name="parrot" data-action="emoji.remove"
it returns following result:
parrot" data-action="emoji.remove

In case of lazy quantifier ("data-emoji-name="(.*?)"") the result will be correct:parrot

get_current_emoji_list function had a greedy quantifier in regexp: "data-emoji-name=\"(.*)\""
I.e. for string like
`data-emoji-name="parrot" data-action="emoji.remove"`
it returns following result:
`parrot" data-action="emoji.remove`

In case of lazy quantifier ("data-emoji-name=\"(.*?)\"") the result will be correct:`parrot`
@smashwilson
Copy link
Owner

👍

@smashwilson smashwilson merged commit 20b1737 into smashwilson:master May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants