fix compilation for caching templates #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Storyxx both seem like accidental typos indeed. Wonder how they went unnoticed for so many years. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We maintain a complex template setup using inheritance and includes.
When activating caching, we get an out of memory error due to a non-terminating recursion.
After stepping through the code there seem to be two possible causes, which when corrected resolve the issue.
The first one being missing parenthesis around the ternary operator which leads to a wrong comparison.
With the second one it seems that the wrong template was compiled.
PHP-version: 8.0
Smarty-version: 4.2.0