Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/strip doesnt remove whitespaces after comment #582

Merged

Conversation

wisskid
Copy link
Member

@wisskid wisskid commented Apr 13, 2020

No description provided.

wisskid added 2 commits April 13, 2020 21:40
…y. Combine equivalent sections in chunks at the template level and strip combined chunks where possible.

- simplified Smarty_Internal_TemplateCompilerBase::processText along the way
Fixes !447
@wisskid wisskid changed the title Bugfix/strip doesnt remove whitespaces after comment 2 Bugfix/strip doesnt remove whitespaces after comment Apr 13, 2020
@wisskid wisskid merged commit 19ef834 into master Apr 13, 2020
@wisskid wisskid deleted the bugfix/strip_doesnt_remove_whitespaces_after_comment_2 branch April 13, 2020 20:29
@glensc
Copy link
Contributor

glensc commented Jul 9, 2020

This is regression to the tsmarty2c tool:

Altho I'd prefer if smarty provided API to walk over nodes:

@wisskid wisskid restored the bugfix/strip_doesnt_remove_whitespaces_after_comment_2 branch August 6, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants