Fixed bug in date_format modifier #458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…estamp if date is NULL
|
I can confirm this changed some months ago and was unexpected
El mié., 4 jul. 2018 13:58, peterader <[email protected]> escribió:
… If the date is NULL it would output the current time instead of simply
returning. Further, the use of "|default:"-"}" is no longer possible due to
this bug.
------------------------------
You can view, comment on, or merge this pull request online at:
#458
Commit Summary
- Fixed bug in date_format modifier, which caused output of current
timestamp if date is NULL
File Changes
- *M* libs/plugins/modifier.date_format.php
<https://github.com/smarty-php/smarty/pull/458/files#diff-0> (4)
Patch Links:
- https://github.com/smarty-php/smarty/pull/458.patch
- https://github.com/smarty-php/smarty/pull/458.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#458>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABH2mQirnXnwvAmEaxP-1x7isQomO8nvks5uDK3VgaJpZM4VCdjN>
.
|
bursonic
approved these changes
Jul 4, 2018
dusta
approved these changes
Aug 12, 2018
|
Hi, When will this change be integrated ? Thanks. |
uwetews
added a commit
that referenced
this pull request
Oct 11, 2018
… did not produce correct output #458
|
The fix is now in the master branch and will later be included in 3.1.34 |
|
When will 3.1.34 be released? This bug just hit us bad... |
|
@uwetews could you please reelase 3.1.34? We had broken builds and had to revert to 3.1.31 too. Thanks! |
|
Ping @uwetews This bug is rather annoying and forces us to update a lot of templates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the date is NULL it would output the current time instead of simply returning. Further, the use of "|default:"-"}" is no longer possible due to this bug.