Treat callables as callables no matter their origin #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cases 4, 5 and 6 will need similar treatment, but I'm unable to setup testing because |
Also try to fix broken PHP 5.3 test.
uwetews
added a commit
that referenced
this pull request
May 27, 2017
…o called as callable to allow closures
#368
|
Case 4 and 5 need no othér treatment as there only functions will be called. |
uwetews
added a commit
that referenced
this pull request
May 27, 2017
uwetews
added a commit
that referenced
this pull request
May 27, 2017
|
Thanks for taking over this. I got the test suite running, but it erroring too much and I yet to get to the errors of interest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #273