Update smarty_internal_compile_capture.php #138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing ().
Without them "{if}", with several "$smarty.capture.X" in condition, generates incorrect code.
e.g. before this change, smarty code
```
{if $smarty.capture.A || $smarty.capture.B}
```
generates code
```php
<?php if (isset($_smarty_tpl->_cache['__smarty_capture']['A']) ? $_smarty_tpl->_cache['__smarty_capture']['A'] : null || isset($_smarty_tpl->_cache['__smarty_capture']['B']) ? $_smarty_tpl->_cache['__smarty_capture']['B'] : null) {?>
```
which evaluates incorrectly.
After this change generated code is
```php
<?php if ((isset($_smarty_tpl->_cache['__smarty_capture']['A']) ? $_smarty_tpl->_cache['__smarty_capture']['A'] : null) || (isset($_smarty_tpl->_cache['__smarty_capture']['B']) ? $_smarty_tpl->_cache['__smarty_capture']['B'] : null)) {?>
```
which evaluates correctly.
uwetews
added a commit
that referenced
this pull request
Dec 19, 2015
|
The patch is now in the master branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing ().
Without them "{if}", with several "$smarty.capture.X" in condition, generates incorrect code.
e.g. before this change, smarty code
generates code
which evaluates incorrectly.
After this change generated code is
which evaluates correctly.