Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.1.24 breaks XML tag output #47

Closed
ghost opened this issue May 31, 2015 · 1 comment
Closed

3.1.24 breaks XML tag output #47

ghost opened this issue May 31, 2015 · 1 comment

Comments

@ghost
Copy link

ghost commented May 31, 2015

This TPL code works with all versions up to 3.1.21:

<?xml version="1.0" encoding="{$modules.Language->getString('html_encoding')}" standalone="no" ?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" dir="{$modules.Language->getString('html_direction')}" lang="{$modules.Language->getLangCode()}" xml:lang="{$modules.Language->getLangCode()}">

3.1.21 outputs

<?xml version="1.0" encoding="UTF-8" standalone="no" ?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" dir="ltr" lang="de-DE" xml:lang="de-DE">

3.1.24 outputs

<?xml version="1.0" encoding="{$modules.Language->getString('html_encoding')}" standalone="no" ?><!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" dir="ltr" lang="de-DE" xml:lang="de-DE">

It basically ignores the first variable?!
uwetews added a commit that referenced this issue Jun 1, 2015
@uwetews
- bugfix <?xml ... ?> including template variables broken since 3.1.22 …
fa269d4 
…#47
@uwetews
Copy link
Contributor

uwetews commented Jun 1, 2015

During optimizations for 2.1.24 I did not think of that template variables could have used inside the tag.
The fix is now in dev-master.

@uwetews uwetews closed this as completed Jun 1, 2015
think-mcunanan pushed a commit to think-mcunanan/smarty that referenced this issue Mar 22, 2023
@think-katou
Merge pull request smarty-php#47 from think-ahead/ticket-#5184-removi…
32d0ef1 
…ng-shift-simulation-functionality-from-shift-master-tab

Redmine #5184: シフト／休日設定画面　メインのかんざしアカウントの休日設定が表示される
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@uwetews