Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of treeToArrayBy and leavesBy #434

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

stellarhoof
Copy link
Member

@stellarhoof stellarhoof commented Feb 5, 2024

Use pushOn instead of push to avoid creating temporary arrays when traversing the tree.

@stellarhoof stellarhoof self-assigned this Feb 5, 2024
Copy link

changeset-bot bot commented Feb 5, 2024

🦋 Changeset detected

Latest commit: 652d71c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
futil-js Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@stellarhoof stellarhoof changed the title feature/improve tree fns perf Improve performance of treeToArrayBy and leavesBy Feb 5, 2024
Copy link
Contributor

github-actions bot commented Feb 5, 2024

Coverage after merging feature/improve-tree-fns-perf into master will be

83.92%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
.yarn/releases
   yarn-3.6.0.cjs11.87%9.15%19.16%50.14%10, 10, 10, 10, 10, 10, 100–101, 101, 101, 103, 103, 103, 103, 103, 103, 103, 103, 106–107, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 111, 111, 111, 115, 115, 115, 117–118, 118, 118–119, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 120, 122, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127,

Copy link
Contributor

github-actions bot commented Feb 5, 2024

Fails
🚫 The changelog has not been updated. Please update the changelog.
🚫 The version was not updated. Please update the version.
Warnings
⚠️ The README has not been updated. Please update the README.
⚠️

Could not run duti:fix command successfully

Messages
📖 Could not find any browser results.

Generated by 🚫 dangerJS against 652d71c

Copy link
Contributor

@daedalus28 daedalus28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a great change

@stellarhoof stellarhoof merged commit 194f400 into master Feb 5, 2024
2 of 3 checks passed
@stellarhoof stellarhoof deleted the feature/improve-tree-fns-perf branch February 5, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants