Update the driver to include smart release v4xx #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smartSRA
changed the title
ghost
linked an issue
…es from Dockerfile
|
After updating the new release link, the build is passing and the PR is ready for a review. |
One simulator which would be used to simulated different sensor types. A new param model introduced which specificies the sesnor to be used. Compose file adopted to run multiple simulators.
Running two services parallel with the same build seem to cause issues and therefore a new service is created. Docker exits as build service exits and does not continue forward hence a timer for port streamer introduced. Readme and actions file adopted respectively
Binaries unpacked only inside the umrr_ros2_driver directory and the simulator adopted to find the binaries. Formatting and grammar checks.
smartBUILDBOT
approved these changes
May 4, 2022
smartBUILDBOT
changed the title
smartBUILDBOT
added a commit
that referenced
this pull request
May 4, 2022
Extended driver to include multi-sensor interfaces and sensors simulators introduced for robust testing. Co-authored-by: Shahrukh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR follows #4 and is ready however the smart access release needs to be updated on our webspace to allow for download of the new release using the script. The build would not pass before that is done.