-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tuya] Add dimmer reversed value support #542
Conversation
Wouldn't this also be possible with the INVERT profile? |
As far as I can see (using the latest OH I could make the case that the addon should actually invert the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM. Since this is also backward compatible we can merge it without any further issues.
...ing.tuya/src/main/java/org/smarthomej/binding/tuya/internal/config/ChannelConfiguration.java
Outdated
Show resolved
Hide resolved
bundles/org.smarthomej.binding.tuya/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
ad3b473
to
076d0fb
Compare
I made the changes based on your comments. |
Looks good. the only thing missing is the documentation. Can you add the parameter to the channel documentation in README.md? |
076d0fb
to
c973723
Compare
I updated the documentation. |
c973723
to
814e427
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the other doc improvements!
Unfortunately there is now a merge conflict after I merged your other PR. Can you fix that? Thanks. |
Signed-off-by: jsetton <[email protected]>
814e427
to
4897c1a
Compare
Done. |
Signed-off-by: jsetton <[email protected]> (cherry picked from commit 8ed983b)
Signed-off-by: jsetton <[email protected]> (cherry picked from commit 8ed983b) (cherry picked from commit e45ae52)
Some dimmer type channel should have the ability to support inverted values. This is useful for the
temp_value
channel which is generally implemented, compared to similar light control addons, from colder (0%) to warmer (100%).