[basicprofiles] State filter profile #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seime
force-pushed
the
conditional_profile
branch
from
0e953b7 to
4511147
Compare
J-N-K
requested changes
Nov 11, 2023
...c/main/java/org/smarthomej/transform/basicprofiles/internal/profiles/StateFilterProfile.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/smarthomej/transform/basicprofiles/internal/profiles/StateFilterProfile.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/smarthomej/transform/basicprofiles/internal/profiles/StateFilterProfile.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/smarthomej/transform/basicprofiles/internal/profiles/StateFilterProfile.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/smarthomej/transform/basicprofiles/internal/profiles/StateFilterProfile.java
Outdated
Show resolved
Hide resolved
| | Configuration Parameter | Type | Description | | ||
| |-------------------------|------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | `conditions` | text | Comma separated list of expressions on the format `ITEM_NAME OPERATOR ITEM_STATE`, ie `MyItem EQ OFF`. Use quotes around `ITEM_STATE` to treat value as string ie `'OFF`' | | ||
| | `mismatchState` | text | Optional state to pass instead if conditions are NOT met. Use quotes to treat as `StringType` | |
There was a problem hiding this comment.
Why is it necessary to quote strings? There is also an issue with the way you split the string. If the comparison value contains a ,, you split in the middle of a string. I know that this is really hard to handle correctly.
There was a problem hiding this comment.
Example why it may be useful (required) to quote strings
I have an aircon with a mode (string) channel. It takes values such as HEAT, COOL, OFFand so on. In order to not re-create state parsing, I've used the OH TypeParser. For a value OFF it will return OnOffType.OFF, and not the string OFF.
I guess I could improve further by checking the item type, but that would also make the same syntax mean 2 different things, and my gut feeling is that there will still be situations where the (hypotetical) user would want the non-default functionality.
Regarding comma as separator between multiple expressions; made this configurable.
seime
force-pushed
the
conditional_profile
branch
from
dd77018 to
9140a9e
Compare
Signed-off-by: Arne Seime <[email protected]>
Signed-off-by: Arne Seime <[email protected]>
Signed-off-by: Arne Seime <[email protected]>
Signed-off-by: Arne Seime <[email protected]>
Signed-off-by: Arne Seime <[email protected]>
Signed-off-by: Arne Seime <[email protected]>
Signed-off-by: Arne Seime <[email protected]>
Signed-off-by: Arne Seime <[email protected]>
Signed-off-by: Arne Seime <[email protected]>
Signed-off-by: Arne Seime <[email protected]>
Signed-off-by: Arne Seime <[email protected]>
seime
force-pushed
the
conditional_profile
branch
from
823ebae to
f8d82ff
Compare
J-N-K
requested changes
Dec 5, 2023
...c/main/java/org/smarthomej/transform/basicprofiles/internal/profiles/StateFilterProfile.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/smarthomej/transform/basicprofiles/internal/profiles/StateFilterProfile.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/smarthomej/transform/basicprofiles/internal/profiles/StateFilterProfile.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/smarthomej/transform/basicprofiles/internal/profiles/StateFilterProfile.java
Outdated
Show resolved
Hide resolved
…rg/smarthomej/transform/basicprofiles/internal/profiles/StateFilterProfile.java
…rg/smarthomej/transform/basicprofiles/internal/profiles/StateFilterProfile.java
…rg/smarthomej/transform/basicprofiles/internal/profiles/StateFilterProfile.java
…rg/smarthomej/transform/basicprofiles/internal/profiles/StateFilterProfile.java
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
stale
J-N-K
added
enhancement
J-N-K
added a commit
that referenced
this pull request
Mar 24, 2024
* State filter profile Signed-off-by: Arne Seime <[email protected]> Co-authored-by: J-N-K <[email protected]> (cherry picked from commit 6104110) Signed-off-by: Jan N. Klug <[email protected]>
J-N-K
added a commit
that referenced
this pull request
Mar 24, 2024
* State filter profile Signed-off-by: Arne Seime <[email protected]> Co-authored-by: J-N-K <[email protected]> (cherry picked from commit 6104110) Signed-off-by: Jan N. Klug <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple filter profile to filter unwanted values originating from a Handler - based on some item(s)' state.
Optional support for replacement state to send instead