Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Setting Choice Set Timeouts #396

Closed
crokita opened this issue Mar 8, 2021 · 0 comments · Fixed by #397
Closed

Fix Setting Choice Set Timeouts #396

crokita opened this issue Mar 8, 2021 · 0 comments · Fixed by #397
Labels
bug Something isn't working

Comments

@crokita
Copy link
Contributor

crokita commented Mar 8, 2021

Bug Report

See equivalent iOS issue for more information: smartdevicelink/sdl_ios#1891
There is additionally no default timeout parameter in the JS choice set class.

Reproduction Steps
  1. Create a new choice set
  2. Update the timeout parameter for a choice set
Expected Behavior

Timeouts should be clamped based on the minimum and maximum allowed values

Observed Behavior

The user is warned about setting a timeout outside the applicable range

Browser & Version Information

All versions and environments affected

@jordynmackool jordynmackool added the bug Something isn't working label Mar 12, 2021
@crokita crokita mentioned this issue Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants