Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SDLChoiceSet default timeout #1891

Closed
joeljfischer opened this issue Jan 15, 2021 · 2 comments · Fixed by #1912
Closed

Fix SDLChoiceSet default timeout #1891

joeljfischer opened this issue Jan 15, 2021 · 2 comments · Fixed by #1912
Assignees
Labels
bug A defect in the library manager-screen Relating to the manager layer - screen managers

Comments

@joeljfischer
Copy link
Contributor

Bug Report

Currently, it's possible for SDLChoiceSet default timeouts to be used incorrectly.

Reproduction Steps
  1. Create a SDLChoiceSet without the timeout set
  2. Update the default timeout of SDLChoiceSet
Expected Behavior

The choice set created before the update uses the new default choice set time

Observed Behavior

The choice set uses the old default choice set time.

OS & Version Information
  • iOS Version: n/a
  • SDL iOS Version: 7.1.0-develop
  • Testing Against: n/a
Test Case, Sample Code, and / or Example App

n/a

@joeljfischer joeljfischer added bug A defect in the library manager-screen Relating to the manager layer - screen managers labels Jan 15, 2021
@NicoleYarroch
Copy link
Contributor

NicoleYarroch commented Feb 4, 2021

Another issue I found was that if the timeout is set to 0, getting the timeout value should return the default timeout value. If the default value is 11, the timeout value should be 11; it actually returns 0.

@NicoleYarroch
Copy link
Contributor

Fixed in #1912

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library manager-screen Relating to the manager layer - screen managers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants